----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39234/#review102258 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Oct. 12, 2015, 2:50 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39234/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2015, 2:50 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi. > > > Bugs: AMBARI-13390 > https://issues.apache.org/jira/browse/AMBARI-13390 > > > Repository: ambari > > > Description > ------- > > whatever user set as value for kafka.metrics.reporters , it's overridden by > ambari agent > /var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py:57 > kafka_server_config['kafka.metrics.reporters'] = > params.kafka_metrics_reporters > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java > dcdbb85 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-broker.xml > 1cbfade > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py > 4d28c41 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py > 0a55504 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java > a54dee2 > > Diff: https://reviews.apache.org/r/39234/diff/ > > > Testing > ------- > > Unit tests passed. > Manually tested upgrade from 2.1.2 to 2.1.3 > > > Thanks, > > Dmytro Sen > >
