----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39413/#review103014 -----------------------------------------------------------
Ship it! Ship It! - Yusaku Sako On Oct. 17, 2015, 1:34 a.m., Xi Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39413/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2015, 1:34 a.m.) > > > Review request for Ambari and Yusaku Sako. > > > Bugs: AMBARI-13461 > https://issues.apache.org/jira/browse/AMBARI-13461 > > > Repository: ambari > > > Description > ------- > > See 3 attached pptx for details. > Also proposing the following changes: > Always show as #e4e4e4 for both by default. That means when the dialog opens, > both are like slide #1 in v3 attached. > When you hover on either one, the color changes to green. See slide #2. > Notice, border is same color as background. > BUT if an option is not available (because checks do no pass OR because it is > not available), then on hover do NOT change the color. Leave it as #e4e4e4 > and have the cursor not-allowed with the tooltip. > Basically, The above eliminate the two colors (moves to just green to > highlight what is being selected). And also makes selection more clear. > > > Diffs > ----- > > ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js > 6a94e6e > ambari-web/app/messages.js 5df161b > ambari-web/app/styles/stack_versions.less 97e1c64 > ambari-web/app/templates/main/admin/stack_upgrade/upgrade_options.hbs > 5902433 > > Diff: https://reviews.apache.org/r/39413/diff/ > > > Testing > ------- > > All UT passed > > > Thanks, > > Xi Wang > >
