-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39471/
-----------------------------------------------------------
Review request for Ambari, Andrii Tkach and Jaimin Jetly.
Bugs: AMBARI-13485
https://issues.apache.org/jira/browse/AMBARI-13485
Repository: ambari
Description
-------
For now some 'displayType' values are stored in site_properties on UI and some
are in stack. I think all displayType values should be moved to stack. In this
case the only UI properties will be 'category' and 'index' (except configs with
'isRequiredByAgent' false and maybe some 'MISC' configs)
Other properties will be fetched ONLY from stack and no UI hardcode.
Diffs
-----
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
e9969d469b481438cadce1356aff016766296a8e
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml
822c449f0db566023bcb0e7bcbac37bc570ac76c
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
5624563d9a2857cbd8e39094ae1def8886e870bf
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
00c15d81450f7efd8ddbe7451949c49d719e61ef
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-startup.properties.xml
90e67ba348d7e2dd23b3c03837d4a84254e6b87e
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-env.xml
5c20c0844b0d3b876ad9db6b28da84081c0f2038
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml
2eeea9c4565aa7c11c29dde0cacfbf5669958100
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml
7b5f0c4c9586a3f2352f67237f1a1866810631ff
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/core-site.xml
a8b5f7bcef414246e1a93cf32736a2233b53d153
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
5319da93e1ab7d9ea29c6da5364886cdc1fc9acd
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml
f0bd6c1191fa2c2281c4262a5e589f6769525b6c
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
0566beb25a4c8d038addadc37ff9d871868df7e9
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
5f211b5de1e291641cbe6e9c2ec8af7072a87039
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-site.xml
980bd320fdf823db244c5c50e4de14537c833f1e
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-broker.xml
6a986487d57450d46aada9dac9f366fc15cbe084
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-env.xml
77bcea0af08d86546ac3082a014507c14847b2a1
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
b7ee2f4a6984c822ed90ec7c83861c80f0e086ee
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
8d9262f4d82ecc878aaedd629ac43f9891e41183
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml
275cbad3f146ad9ac7201a5fedb1c5b060676524
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
130b0d144a2dda04248b49626756a25c55a796db
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml
69cb39f3447f1dfd2fee440c631e6ef7c5b6eb51
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml
be5e465ab1883bec59bda38ec3c282f1ce97cc0f
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml
b7453f92ef9f5c285adc1b9d1896c79a635b1c4b
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml
c4285955de7544280aea9be1eeb477b3df694d4e
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-env.xml
58db2f3da98635cae131bf27475eadab05edcd67
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-env.xml
4becae6668fab2f3eccf9a441ee8f559c2174e08
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml
3592ec03db6f4d053fa22bf2aa4e2002eb36d873
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/configuration/zoo.cfg.xml
37e9c0def5581aa72bdf6d419baa3274776d8faa
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/configuration/zookeeper-env.xml
83caac207735aede4c326f1ef04168885f746b6c
ambari-server/src/main/resources/stacks/BIGTOP/0.8/configuration/cluster-env.xml
ae3c6e9596038edeca40efc40713d5705f970a65
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/YARN/configuration/yarn-site.xml
20052de1691821857249426bdb4f9d083378935a
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
98d43a59fcf5624cae5e813cb30657d0a571dd10
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
4f78228205a2c1a4d8ab942bc36bc8b2686b80d6
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-env.xml
a069962eb70643638020d2385659e614454ddc75
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-site.xml
23f9c30592a98570f5aba10abf72bc79a4d8f9e1
ambari-server/src/main/resources/stacks/HDP/2.2/services/FALCON/configuration/falcon-startup.properties.xml
5d1daa8740c0341cca06d1a39fb2d3deddd92579
ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml
d6048bbbcd7927e98769aca938459880132c28cf
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml
2b3907e3c1f2dd07347c2c4272c5603dc2e38787
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
236c4e8f54596cff8b16692b5ee3af72df6531bd
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml
9e98b57425a8a723eb7a2b05691c4043c30e3199
ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml
d698165ce5ca77a4330b99003cb5bc770c67250e
ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/storm-site.xml
884b3f13a34126e456bf1eb5aeda04504b503d73
ambari-server/src/main/resources/stacks/HDP/2.2/services/TEZ/configuration/tez-site.xml
72873b71267676dd12ef81f8dc21c5a58bfe2a08
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
c69fd39c25afdb8526656ab69080377d857a6843
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/hbase-site.xml
32ad416beab1bc05b5798cd7b461db0a0242d4c3
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml
ec5aa29001c18a30d95d2fa42d00a670d4b18d14
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hdfs-site.xml
fbce6e87a858136fdca11ad9bcabe5809c5384f2
ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml
f29f6112d475e93cf7c8a0ca0af1e02d76d715f5
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml
aea58576c5aa57c9aa796c796b2b10f09ef4d22f
ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml
2227f532797edf37ff2dec6d6990a14f39045c1a
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-plugin-properties.xml
c7723f60ef00c14b30c2255aabe0b4140b3a72b5
ambari-web/app/data/HDP2.2/site_properties.js
55d398fa3aec241411d0f73e4d131d4dfb62dda8
ambari-web/app/data/HDP2.3/site_properties.js
320130189d53f45274f93ca34bfaa6c09bb8b8e7
ambari-web/app/data/HDP2/gluster_fs_properties.js PRE-CREATION
ambari-web/app/data/HDP2/site_properties.js
66fda2add67e3ad82a90fe5e09ca3a40641b67ea
ambari-web/app/mixins/common/configs/configs_comparator.js
cda54071a8480b13c1999775194ad3c2afd9dff3
ambari-web/app/models/configs/objects/service_config_property.js
100de5d993710bedbb7262e3906aae425261eaf4
ambari-web/app/utils/config.js fc472214c7a9da0194cec7f4d36fff22fe1a3ad7
ambari-web/app/views/common/configs/service_configs_by_category_view.js
a2080d0a22cc7b2e3aff3e14e2236597af83f915
ambari-web/test/controllers/main/admin/kerberos/step2_controller_test.js
701fcf32d7eb28b915c71c0fbd98034fc8a4e84e
ambari-web/test/controllers/main/service/info/config_test.js
a62c75fd6d3110db2dea5fc5356eff391e2d88f2
ambari-web/test/data/HDP2.2/site_properties_test.js
5c88198225070568d9300208d5b1fa4406b952d4
ambari-web/test/data/HDP2.3/site_properties_test.js
86e83f056c8d248675945b1cbe8c751063a4fe03
ambari-web/test/data/HDP2/site_properties_test.js
9310fbf994b073b8d0940da2999a83042fee5387
ambari-web/test/mock_data_setup/configs_mock_data.js
8c46b2fbf3e00a5be763c52d89f466e0a5f4e994
ambari-web/test/utils/config_test.js 4a420533133a0e2718ea7c673e8d195c0f49d844
ambari-web/test/views/common/configs/service_configs_by_category_view_test.js
f9ec76469aa0ef6f4c262c94bab5300cc3912f87
Diff: https://reviews.apache.org/r/39471/diff/
Testing
-------
10061 tests complete (11 seconds)
105 tests pending
Thanks,
Andriy Babiichuk
