----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/#review103540 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java (line 856) <https://reviews.apache.org/r/39519/#comment161596> Let's output a full path to file here (easier troubleshooting) ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java (line 197) <https://reviews.apache.org/r/39519/#comment161597> Seems dangerous to me. If customer's cluster has primitive hostnames without domain name (like host1, host2,.. host10 and so on), then replacing host1 will also affect host10 in configs. How about doing it via regex that enforces that there is no alfanumeric characters right after replacement? - Dmitro Lisnichenko On Oct. 21, 2015, 9:04 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39519/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 9:04 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav > Papirkovskyy, and Sumit Mohanty. > > > Bugs: AMBARI-13507 > https://issues.apache.org/jira/browse/AMBARI-13507 > > > Repository: ambari > > > Description > ------- > > At a high-level we may follow this approach: > Ensure cluster is not kerberized > Assume all services to be stopped (add a check to ensure that services are > stopped) > We may also need to check and confirm that there are no commands pending > execution - or just mark them as aborted > Update all host names in the database based on the mapping provided (e.g. > host1 --> master01.dev.com) > As SQLClient cannot be assumed consider using jdbc - similar to the Upgrade > code > Modify all configs to replace the hostnames as needed (not sure if plain > search and replace will suffice) > Agents need to be re-configured if ambari-server hostname changes > > > Diffs > ----- > > ambari-server/sbin/ambari-server 1843cd6 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 702e12d > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 62c3b61 > > ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > ed68313 > ambari-server/src/main/python/ambari-server.py 88df81a > ambari-server/src/main/python/ambari_server/hostUpdate.py PRE-CREATION > ambari-server/src/main/python/ambari_server/setupActions.py 6c6e7ea > > Diff: https://reviews.apache.org/r/39519/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
