> On Oct. 27, 2015, 5:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java, > > line 224 > > <https://reviews.apache.org/r/39700/diff/1/?file=1109778#file1109778line224> > > > > Doc it?
ok > On Oct. 27, 2015, 5:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java, > > line 211 > > <https://reviews.apache.org/r/39700/diff/1/?file=1109777#file1109777line211> > > > > Doc it? ok > On Oct. 27, 2015, 5:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java, > > line 210 > > <https://reviews.apache.org/r/39700/diff/1/?file=1109775#file1109775line210> > > > > Document this in the javadoc ok > On Oct. 27, 2015, 5:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java, > > lines 201-204 > > <https://reviews.apache.org/r/39700/diff/1/?file=1109775#file1109775line201> > > > > I prefer named parameters like :clusterId because then you know that > > you're explictely setting it right on the query object. But this works the > > same, too. For named queries where the "source" isn't right there I agree, but since this was all "local" - meh :) > On Oct. 27, 2015, 5:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java, > > line 196 > > <https://reviews.apache.org/r/39700/diff/1/?file=1109775#file1109775line196> > > > > You can probably just get the EM once and reuse it. It should be the > > same since it's a thread local, but might as well hold onto it. will do > On Oct. 27, 2015, 5:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java, > > lines 776-780 > > <https://reviews.apache.org/r/39700/diff/1/?file=1109774#file1109774line776> > > > > Should this be in reverse order for any reason (thinking about > > transactions). Should it be host components, hosts, and finally cluster? Not sure - logically that seems sound. I'll make the change. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39700/#review104210 ----------------------------------------------------------- On Oct. 27, 2015, 5:08 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39700/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 5:08 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and > Jonathan Hurley. > > > Bugs: AMBARI-13591 > https://issues.apache.org/jira/browse/AMBARI-13591 > > > Repository: ambari > > > Description > ------- > > {{ambari-server --set-current}} should have an additional option to set a > version to current. Existing functionality takes the information passed in > and calls the Finalize action. This attempts to go through the framework and > "cleanly" make sure all the versions are correct by applying the same logic > as finalize. > > Add a {{--force}} option to do the db work directly without going through the > finalize action, modeled after what the RU magician does. If work is small > enough, possible backport to 2.1.3. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 2a1431d > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java > 8d4c5ee > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentDesiredStateDAO.java > 2620c8c > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java > d5707be > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java > ad617af > ambari-server/src/main/python/ambari-server.py 2fae1ee > ambari-server/src/main/python/ambari_server/serverUpgrade.py 7048812 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java > 1819ef9 > ambari-server/src/test/python/TestServerUpgrade.py 7ef74b2 > > Diff: https://reviews.apache.org/r/39700/diff/ > > > Testing > ------- > > Manual verification. Automated pending. > > > Thanks, > > Nate Cole > >
