-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39743/#review104511
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py
 (line 81)
<https://reviews.apache.org/r/39743/#comment162760>

    We were trying to cat the file without first checking its existence.



ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py
 (line 111)
<https://reviews.apache.org/r/39743/#comment162759>

    This Dir was missing.


- Alejandro Fernandez


On Oct. 30, 2015, 1:56 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39743/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 1:56 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, Jayush Luniya, Nate Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-13595
>     https://issues.apache.org/jira/browse/AMBARI-13595
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Allow Storm service to be upgraded/downgraded during Express Upgrade in the 
> following paths,
> HDP 2.1->2.3  (this path requires removing STORM_REST_API component first)
> HDP 2.2->2.2.*
> HDP 2.2->2.3
> HDP 2.3->2.3.*
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  fef4f7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/StormRestAPIDeletedCheck.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java
>  536a5ad 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py
>  e1cb5ba 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
>  6f8d5b0 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py
>  f9d64f4 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py
>  9c36a78 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py
>  3210d8a 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py
>  5d90f5b 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py
>  2e9557a 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py
>  5d01dc6 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py
>  335aeeb 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py
>  f3074f1 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py
>  abe144f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
>  f8dcd8a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml
>  b4b4603 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  b043879 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 
> 11f718d 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> 688417e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  ef1835b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 7dbc87b 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py 
> 5211a02 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 323f3ef 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus_prod.py 
> e1506d8 
>   
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 
> 0419b3c 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor.py 
> 742556e 
>   
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py 
> 631a9ed 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 
> b16104b 
> 
> Diff: https://reviews.apache.org/r/39743/diff/
> 
> 
> Testing
> -------
> 
> Testing during Express Upgrade.
> Python unit tests passed.
> 
> ----------------------------------------------------------------------
> Total run:825
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Reply via email to