-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39728/
-----------------------------------------------------------
(Updated Nov. 2, 2015, 1:53 p.m.)
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-13606
https://issues.apache.org/jira/browse/AMBARI-13606
Repository: ambari
Description
-------
Created FilePreviewService API which takes start index and end index as
parameter and returns all the bytes between start index and end index.
Consuming FilePreviewService API on UI. Loading next page on scroll of the
result container. User can download also from the preview modal window.
Diffs (updated)
-----
contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java
9224331
contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FilePreviewService.java
PRE-CREATION
contrib/views/files/src/main/resources/ui/app/adapter.js 6ec763b
contrib/views/files/src/main/resources/ui/app/controllers/file.js cf87041
contrib/views/files/src/main/resources/ui/app/controllers/files.js 22cbb7a
contrib/views/files/src/main/resources/ui/app/controllers/previewModal.js
PRE-CREATION
contrib/views/files/src/main/resources/ui/app/initialize.js fc6cbc7
contrib/views/files/src/main/resources/ui/app/routes/file.js ee6a45a
contrib/views/files/src/main/resources/ui/app/templates/modal/preview.hbs
PRE-CREATION
contrib/views/files/src/main/resources/ui/app/views/modalPreview.js
PRE-CREATION
contrib/views/files/src/main/resources/ui/bower.json b7cb52a
contrib/views/files/src/main/resources/ui/package.json 1fab7e8
Diff: https://reviews.apache.org/r/39728/diff/
Testing
-------
mvn clean install
-------------------------------------------------------
T E S T S
-------------------------------------------------------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.ambari.view.filebrowser.FilebrowserTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.907 sec
Results :
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ files ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .git/
[INFO] Exclude: **/.gitignore
[INFO] Exclude: **/.gitattributes
[INFO] Exclude: .idea/
[INFO] Exclude: pass.txt
[INFO] Exclude: .DS_Store
[INFO] Exclude: .iml/
[INFO] Exclude: .classpath
[INFO] Exclude: .project
[INFO] Exclude: .settings
[INFO] Exclude: **/target/**
[INFO] Exclude: **/.gitkeep
[INFO] Exclude: **/.bowerrc
[INFO] Exclude: **/.editorconfig
[INFO] Exclude: **/.jshintrc
[INFO] Exclude: **/.tmp/**
[INFO] Exclude: **/tmp/**
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.svg
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/bin
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/public/**
[INFO] Exclude: **/dist/**
[INFO] Exclude: **/bower_components/**
[INFO] Exclude: **/bower/**
[INFO] Exclude: **/node/**
[INFO] Exclude: **/runner.js
[INFO] Exclude: **/assets/javascripts/**
[INFO] Exclude: **/assets/stylesheets/**
[INFO] Exclude: **/assets/static/javascripts/**
[INFO] Exclude: **/assets/static/stylesheets/**
[INFO] Exclude: storm/src/main/resources/**
[INFO] 77 resources included (use -debug for more details)
Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
recognized.
Compiler warnings:
WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property
'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
Warning: org.apache.xerces.parsers.SAXParser: Feature
'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property
'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0
approved: 71 licence.
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ files ---
[INFO] Building jar:
/Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0.0-SNAPSHOT.jar
[INFO]
[INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ files ---
[INFO] Reading assembly descriptor:
/Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
[INFO]
[INFO] --- maven-install-plugin:2.4:install (default-install) @ files ---
[INFO] Installing
/Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0.0-SNAPSHOT.jar
to
/Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0.0-SNAPSHOT/files-1.0.0.0.0-SNAPSHOT.jar
[INFO] Installing
/Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/pom.xml
to
/Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0.0-SNAPSHOT/files-1.0.0.0.0-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:47.554s
[INFO] Finished at: Thu Oct 29 00:01:17 IST 2015
[INFO] Final Memory: 44M/546M
[INFO] ------------------------------------------------------------------------
Thanks,
Pallav Kulshreshtha
