----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39746/#review104797 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/PXF/3.0.0.0/package/scripts/pxf.py (line 96) <https://reviews.apache.org/r/39746/#comment163040> Perhaps we should abstract this, store it as a constant. - Alejandro Fernandez On Oct. 29, 2015, 3:40 a.m., Matt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39746/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 3:40 a.m.) > > > Review request for Ambari. > > > Repository: ambari > > > Description > ------- > > Define Configure, start, stop, and status methods for Apache HAWQ's PXF. > Ensure that PXF service can be installed, started and stopped through Ambari. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/PXF/3.0.0.0/configuration/pxf-site.xml > PRE-CREATION > ambari-server/src/main/resources/common-services/PXF/3.0.0.0/metainfo.xml > 4df1bd6 > > ambari-server/src/main/resources/common-services/PXF/3.0.0.0/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/PXF/3.0.0.0/package/scripts/pxf.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/PXF/3.0.0.0/package/scripts/pxfservice.py > c267794 > > ambari-server/src/main/resources/common-services/PXF/3.0.0.0/package/templates/pxf-env.j2 > PRE-CREATION > > Diff: https://reviews.apache.org/r/39746/diff/ > > > Testing > ------- > > Testing was done manually > > > Thanks, > > Matt > >
