----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39952/#review105149 -----------------------------------------------------------
Thanks for doing this so quickly! This has been pushed. Please go ahead and close the review. - Nate Cole On Nov. 4, 2015, 3:38 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39952/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 3:38 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush > Luniya, Mahadev Konar, and Nate Cole. > > > Bugs: AMBARI-13722 > https://issues.apache.org/jira/browse/AMBARI-13722 > > > Repository: ambari > > > Description > ------- > > When failures are skipped in the Upgrade Wizard, there's a manual > confirmation step that is injected. > > {code} > "Manual steps required" > Verifying Skipped Failures > > [ ] I have performed the manual steps above. > > [Pause Upgrade] [Proceed] <- [Downgrade] was missing, but that's a different > issue > {code} > > This doesn't really make sense to the end user. > So the full scope if this jira becomes changes to structuredOut to > incorporate auto-skipped detail (hosts and services/components) and failures > (hosts and services/components) > > {code} > { > "failures":{ > "service_check":[ > "ZOOKEEPER" > ], > "host_component":{ > "host1.vm":[ > { > "component":"DATANODE" > } > ], > "host2.vm":[ > { > "component":"DATANODE" > } > ] > } > }, > "skipped":[ > "service_check", > "host_component" > ] > } > > {code} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java > f5642a0 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java > 9a84e38 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryActionTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/39952/diff/ > > > Testing > ------- > > running full unit tests, should be good > > > Thanks, > > Dmitro Lisnichenko > >
