----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40141/#review105903 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java (lines 781 - 783) <https://reviews.apache.org/r/40141/#comment164597> Here you are using cluster.getDesiredConfigByType(HIVE_ENV_CONFIG) twice, i think it will be better to get once and use twice. ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java (line 792) <https://reviews.apache.org/r/40141/#comment164598> We have a constant for "content" property - Vitalyi Brodetskyi On Лис. 10, 2015, 4:23 після полудня, Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40141/ > ----------------------------------------------------------- > > (Updated Лис. 10, 2015, 4:23 після полудня) > > > Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi. > > > Bugs: AMBARI-13817 > https://issues.apache.org/jira/browse/AMBARI-13817 > > > Repository: ambari > > > Description > ------- > > It could be as simple as making sure that > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml > has the same changes as in the 2.2. version > (ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml). > Specifically the missing parts are: > export SERVICE=$SERVICE > if [ "$SERVICE" = "metastore" ]; then > export HADOOP_HEAPSIZE="{{hive_metastore_heapsize}}" > else > export HADOOP_HEAPSIZE="{{hive_heapsize}}" > fi > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java > 3211b36 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > 447993d > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml > c331802 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml > 30141c6 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java > 521dede > > Diff: https://reviews.apache.org/r/40141/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
