----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40138/#review105908 -----------------------------------------------------------
Ship it! Patch looks great to me. Just a few minor issues that probably should be fixed. ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java (line 5428) <https://reviews.apache.org/r/40138/#comment164600> Minor issue: I'd recommend making this variable a "final" one. Since this variable is used later for the assertion, the final declaration will prevent anyone from accidentally modifying this test in such a way that this invariant is modified. ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java (line 5465) <https://reviews.apache.org/r/40138/#comment164601> Minor issue: Same as above, maybe just make this variable final. - Robert Nettleton On Nov. 10, 2015, 5:40 p.m., Sebastian Toader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40138/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 5:40 p.m.) > > > Review request for Ambari, Robert Nettleton and Sumit Mohanty. > > > Bugs: AMBARI-13815 > https://issues.apache.org/jira/browse/AMBARI-13815 > > > Repository: ambari > > > Description > ------- > > This is the first version of the patch that was tested manually. Unit tests > currently running. > > This patch updates the ranger and ranger kms server specific properties > within the BlueprintProcessor. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 0ed2eef > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 424baee > > Diff: https://reviews.apache.org/r/40138/diff/ > > > Testing > ------- > > Performed manual testing of deploying a 3 node cluster with Blueprints > (having Ranger with MySql, Ranger KMS, HDFS, YARN, Metrics, Knox , Tez > services). Also tested the Ranger HA deployment (using httpd as load > balancer). > > > Unit tests: > Results : > > Tests run: 3358, Failures: 0, Errors: 0, Skipped: 35 > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:11:11.266s > [INFO] Finished at: Tue Nov 10 17:52:10 CET 2015 > [INFO] Final Memory: 32M/548M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sebastian Toader > >
