> On Nov. 5, 2015, 6:19 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml, > > line 260 > > <https://reviews.apache.org/r/39937/diff/1/?file=1115713#file1115713line260> > > > > Alejandro is right - we keep the changed values. However, for RU we'll > > still process a straight set (not sure about EU). > > Dmitro Lisnichenko wrote: > I tested RU and EU. I changed tez.lib.uris to > /hdp/apps/2.2.9.0-3336/tez/tez.tar.gz before upgrade and it was set to > /hdp/apps/${hdp.version}/tez/tez.tar.gz after. > > Alejandro Fernandez wrote: > I find this odd, since there's nothing special about this property. > Meaning, if I change prop1 from value_foo -> value_bar, and tez.lib.uris > from default_in_stack_22 -> custom_path. > Then these properties need different treatmeant; prop1 should keep > value_foo, but tez.lib.uris should be forced to default_in_stack_23
Any word on how this is working for both of those cases? It would seem that this requires a different annotation to force it to a property value when merging configs. Please correct me if I'm wrong. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39937/#review105282 ----------------------------------------------------------- On Nov. 4, 2015, 4:58 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39937/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 4:58 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush > Luniya, and Nate Cole. > > > Bugs: AMBARI-13713 > https://issues.apache.org/jira/browse/AMBARI-13713 > > > Repository: ambari > > > Description > ------- > > Customers apply hotfixes for Tez by modifying tez.lib.uris to point to a new > tez tarball to avoid affecting currently running jobs. > > When Ambari does an upgrade to a future version, this config should be > reverted to point to the newly uploaded tez tarball ( from the upgraded > version ). > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml > ad9346e > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml > 14bd266 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml > c9ba8d2 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > 06e5859 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml > f210930 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 5b78cfd > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > 53329ee > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > 016bad6 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml > b0bd7d9 > > Diff: https://reviews.apache.org/r/39937/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
