> On Nov. 11, 2015, 3:39 p.m., Andrew Onischuk wrote: > > -1 for such an approach this will make repo data cleaned on every install > > task. Which will make package installation in every task refresh all > > repositories which makes all the installs much slower. > > If we really want to do this we should do it once, and not every install > > task. > > Andrew Onischuk wrote: > This is the reason why it wasn't implemented in the first place. Because > there was a bunch of issues like this from guys testing Ambari. We should > think of better mechanism to handle this issue. > > P.s. Please see https://issues.apache.org/jira/browse/AMBARI-10992 some > customers are really critical about the tasks times.
hello Andrew, Clean cache logic is in the Repository Python scripts, it happens after the repo file is installed, not per package install. For rolling upgrade, after the repo file is created on each node, the clean cache logic runs against the specific repo ids used for the rolling upgrade, and that is it, all subsequent package installations will not trigger the cache clean logic. For fresh install, also after the repo file is created on each node, the same clean cache logic runs. The repo init logic in the BEFORE-INSTALL hook repo_initialization.py script also has a check to skip the whole repo creation (which includes the clean cache) based on "host_sys_prepped" property value from params.py. - Di ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40080/#review106066 ----------------------------------------------------------- On Nov. 10, 2015, 9:02 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40080/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 9:02 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jayush > Luniya, and Sid Wagle. > > > Bugs: AMBARI-13748 > https://issues.apache.org/jira/browse/AMBARI-13748 > > > Repository: ambari > > > Description > ------- > > Need a way for Ambari to trigger a repository clean (yum clean expire-cache > on rhel, for example) when updating repository files during an Ambari update > as well as fresh installation of a cluster. > > Currently, this must be done occasionally through a manual step, and if not > done will lead to problems during install. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/providers/repository.py > 11002cc > > ambari-common/src/main/python/resource_management/libraries/resources/repository.py > 2484d67 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > 1dfaa54 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 05751fa > ambari-server/src/test/python/custom_actions/TestInstallPackages.py 83b6bb5 > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py > f9d69a8 > > Diff: https://reviews.apache.org/r/40080/diff/ > > > Testing > ------- > > New unit test. Patch cluster with the changes and run fresh install and > rolling upgrade to verify the repo clean up logic was run. > > > Thanks, > > Di Li > >
