[ 
https://issues.apache.org/jira/browse/AMBARI-12537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000649#comment-15000649
 ] 

Hadoop QA commented on AMBARI-12537:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12771740/AMBARI-12537.v1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-server.

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/4255//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/4255//console

This message is automatically generated.

> Blueprints Cluster configuration task thread should not wait indefinitely
> -------------------------------------------------------------------------
>
>                 Key: AMBARI-12537
>                 URL: https://issues.apache.org/jira/browse/AMBARI-12537
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.1.1
>            Reporter: Robert Nettleton
>            Assignee: Laszlo Puskas
>            Priority: Critical
>             Fix For: 2.1.3
>
>         Attachments: AMBARI-12537.v1.patch
>
>
> There are a few instances of a threading pattern in the Blueprints 
> configuration processor that should be modified slightly to avoid an 
> indefinite wait in the case of an error condition. 
> The TopologyManager.ClusterConfigureTask demonstrates this problem, where a 
> thread will sleep repeatedly, and then loop infinitely if a condition is not 
> reached.  
> In the error scenario, this could potentially keep the thread running 
> indefinitely, which is a waste of resources.  
> The TopologyManager.ClusterConfigureTask, and perhaps other scenarios like 
> this in Blueprints as well, should be modified to include some kind of 
> timeout on these waiting threads.  If the condition is not met within a 
> reasonable amount of time, the thread should log that condition and exit.   
> Leaving the thread to execute indefinitely for a condition that will never be 
> met is wasting resources, and should be addressed.  
> This configuration timeout may need to be configurable as well, since 
> different cluster sizes will have different timing issues.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to