----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40198/#review106287 -----------------------------------------------------------
Ship it! Ship It! - Jayush Luniya On Nov. 12, 2015, 3:36 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40198/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 3:36 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole. > > > Bugs: AMBARI-13845 > https://issues.apache.org/jira/browse/AMBARI-13845 > > > Repository: ambari > > > Description > ------- > > The ability to automatically skip failures on skippable components is being > expanded to master components incorrectly. This is because those non-core > masters are considered to be skippable in general. > > The best way to fix this is to adjust the upgrade packs to break out the > master components into their own groupings which can be annotated with > > {code} > <skippable>true</skippable> > <supports-auto-skip-failure>false</supports-auto-skip-failure> > {code} > > This will apply to: > - Ranger > - Spark > - Oozie > - Falcon > > {code:title=Example} > <group name="SPARK" title="Spark"> > <skippable>true</skippable> > <service-check>false</service-check> > <supports-auto-skip>false</supports-auto-skip> > <service name="SPARK"> > <component>SPARK_JOBHISTORYSERVER</component> > </service> > </group> > > <group name="SPARK_CLIENTS" title="Spark Clients"> > <skippable>true</skippable> > <service name="SPARK"> > <component>SPARK_CLIENT</component> > </service> > </group> > {code} > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml > 4f286ae > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml > 40cb607 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > 9a4ddb0 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml > a71ad45 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > d318a3a > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > 25620af > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml > e419133 > > Diff: https://reviews.apache.org/r/40198/diff/ > > > Testing > ------- > > Ran through an update and verified that forced failures didn't auto skip > non-core masters. > > > Thanks, > > Jonathan Hurley > >
