----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40270/#review106360 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPaddingMethod.java (line 119) <https://reviews.apache.org/r/40270/#comment165095> Does this mean default seconds padding interval is 1 second? - Sid Wagle On Nov. 13, 2015, 1:25 a.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40270/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2015, 1:25 a.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-13863 > https://issues.apache.org/jira/browse/AMBARI-13863 > > > Repository: ambari > > > Description > ------- > > Problem > On the Ambari dashboard page, when different time ranges are randomly chosen, > the metrics charts stop responding and an OutOfMemory is seen in the Ambari > server logs. > > Bug > In the AMS cache layer, the logic to pad the cache entry map by looking at > the delta between the values present in the map. When there is only one data > point, it assumes a default pad interval of 15 seconds even if the actual > data precision could be in minutes/hours/days. > > Fix > Change the padding interval logic to use the precision calculated using the > requested start and end time. If the precision is in SECONDS, the delta > between the values in the map are used. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPaddingMethod.java > ccfb713 > > ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/MetricsPaddingMethodTest.java > b35295d > > Diff: https://reviews.apache.org/r/40270/diff/ > > > Testing > ------- > > Added unit test for new padding interval calculation method. Relevant unit > tests pass. > > Submitted a patch at Apache to run other unit tests. > > > Thanks, > > Aravindan Vijayan > >
