> On Sept. 29, 2015, 7:42 a.m., Andrew Onischuk wrote: > > The code LGTM. The only thing I want to ask is are you sure that oozie > > client works fine without password in configurations? Can you give some > > references or results of what you want tried? > > Sangeeta Ravindran wrote: > Hi Andrew, > > Sorry for not getting back to you earlier. The Oozie client will work > fine without db password as it depends mainly on RESTful APIs. Testcase > org.apache.ooze.client.TestOozieCLI. > > Thanks, > Sangeeta
Hi Andrew, Yusaku, Can you please let me know if any further changes are needed in this jira? Thanks, Sangeeta - Sangeeta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38748/#review100939 ----------------------------------------------------------- On Sept. 27, 2015, 6:08 p.m., Sangeeta Ravindran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38748/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2015, 6:08 p.m.) > > > Review request for Ambari and Andrew Onischuk. > > > Bugs: AMBARI-11967 > https://issues.apache.org/jira/browse/AMBARI-11967 > > > Repository: ambari > > > Description > ------- > > When Oozie Client Configs are downloaded from the Ambari UI, the > oozie-site.xml included in the tar.gz file contains the value of the > oozie.service.JPAService.jdbc.password field. > > The password should not be included in the downloaded client config file. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > dea0362 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 62c3b61 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java > 7643abb > > Diff: https://reviews.apache.org/r/38748/diff/ > > > Testing > ------- > > Manual testing. Updated JUnit test case. Ran mvn clean test. > > > Thanks, > > Sangeeta Ravindran > >
