> On Nov. 13, 2015, 6:40 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/custom_actions/scripts/clear_repocache.py, > > line 22 > > <https://reviews.apache.org/r/40080/diff/4/?file=1125081#file1125081line22> > > > > Let's avoid import * since it's been known to cause issues.
hello Alejandro, I just updated the python script to have explicit imports. Thanks. - Di ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40080/#review106477 ----------------------------------------------------------- On Nov. 13, 2015, 1:56 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40080/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2015, 1:56 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jayush > Luniya, and Sid Wagle. > > > Bugs: AMBARI-13748 > https://issues.apache.org/jira/browse/AMBARI-13748 > > > Repository: ambari > > > Description > ------- > > Need a way for Ambari to trigger a repository clean (yum clean expire-cache > on rhel, for example) when updating repository files during an Ambari update > as well as fresh installation of a cluster. > > Currently, this must be done occasionally through a manual step, and if not > done will lead to problems during install. > > > Diffs > ----- > > > ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml > e725d68 > ambari-server/src/main/resources/custom_actions/scripts/clear_repocache.py > PRE-CREATION > ambari-server/src/test/python/custom_actions/TestClearRepoCache.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/40080/diff/ > > > Testing > ------- > > New unit test. Patch cluster with the changes and run fresh install and > rolling upgrade to verify the repo clean up logic was run. > > New unit test for custom action code change. Also test the custom action by > REST API call > > > curl -u admin:admin -H "X-Requested-By: admin" -X POST > -d'{"RequestInfo":{"context":"clear repo cache test", "action" : > "clear_repocache"}, > "Requests/resource_filters":[{"hosts":"agent.mydomain.com"}]}' > http://server.mydomain.com:8080/api/v1/clusters/bi/requests > > > Thanks, > > Di Li > >
