----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40621/#review107678 -----------------------------------------------------------
Ship it! ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/upgrade.py (line 50) <https://reviews.apache.org/r/40621/#comment166909> ACL in all caps - Jonathan Hurley On Nov. 23, 2015, 6:46 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40621/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2015, 6:46 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan > Hurley, Jayush Luniya, Nate Cole, and Swapan Shridhar. > > > Bugs: AMBARI-14027 > https://issues.apache.org/jira/browse/AMBARI-14027 > > > Repository: ambari > > > Description > ------- > > STR: > > * Ambari 2.2 rpm 324 > * HDP 2.3.0.0-2557 > * Installed HDFS, MR, YARN, ZK, Kafka > * Added NameNode HA > * Installed repo for HDP 2.3.4.0-3262 and distributed bits > * Installed repo for HDP 2.3.4.0-3278 and distributed bits > * Started Express Upgrade to 2.3.4.0-3262 > > > Failed on Kafka, > ``` > Traceback (most recent call last): > File > "/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py", > line 101, in <module> > KafkaBroker().execute() > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", > line 218, in execute > method(env) > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", > line 497, in restart > self.pre_upgrade_restart(env, upgrade_type=upgrade_type) > File > "/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py", > line 68, in pre_upgrade_restart > upgrade.run_migration(env, upgrade_type) > File > "/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/upgrade.py", > line 65, in run_migration > raise Fail("Could not retrieve Zookeeper Port number for localhost from > property kafka-broker/zookeeper.connect") > resource_management.core.exceptions.Fail: Could not retrieve Zookeeper Port > number for localhost from property kafka-broker/zookeeper.connect > ``` > > This needs to be ran on a kerberized cluster only, and should use the full > zookeeper.connect property now that the most recent Kafka builds support it > (before they only accepted a single value, now they take a list of hosts with > port numbers). > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py > 04490fc > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/upgrade.py > 0457525 > > Diff: https://reviews.apache.org/r/40621/diff/ > > > Testing > ------- > > Tested on by kerberizing a cluster with Kafka and performing an Express > Upgrade from HDP 2.3.2.0 to 2.3.4.0 > Python unit tests passed. > > ---------------------------------------------------------------------- > Total run:836 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
