----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40763/#review108405 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py (line 282) <https://reviews.apache.org/r/40763/#comment167872> Why the sleep? If there's a timing issue or race condition, we should at least document it in the code. - Alejandro Fernandez On Nov. 27, 2015, 12:33 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40763/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2015, 12:33 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, > Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: AMBARI-14094 > https://issues.apache.org/jira/browse/AMBARI-14094 > > > Repository: ambari > > > Description > ------- > > Patch contains changes to remove Fail() for Ranger repository creation. Also > added 30 seconds sleep time to check for Ranger service. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > 905ec1d > > Diff: https://reviews.apache.org/r/40763/diff/ > > > Testing > ------- > > Tested for Start all case and checked for Ranger HA and KMS service start > together. > > ---------------------------------------------------------------------- > Ran 271 tests in 8.044s > > OK > ---------------------------------------------------------------------- > Total run:878 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Gautam Borad > >
