> On Dec. 1, 2015, 4:25 a.m., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/functions.py, > > line 34 > > <https://reviews.apache.org/r/40812/diff/1/?file=1149479#file1149479line34> > > > > What happens with 1000 instead of 1000m?
The value passed to this method will always be of the format "1000m" because of Line 114. regionserver_heapsize = check_append_heap_property(str(regionserver_heapsize), "m") - Aravindan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40812/#review108449 ----------------------------------------------------------- On Dec. 1, 2015, 3:51 a.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40812/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2015, 3:51 a.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-14120 > https://issues.apache.org/jira/browse/AMBARI-14120 > > > Repository: ambari > > > Description > ------- > > PROBLEM > On Version 2.1.2, AMS had no "m" in the heap properties in the > ams-hbase-env.sh and ams-env templates and the user was expected to specify > the "m" suffix through the UI config. > > On Version 2.1.3, AMS had the "m" suffix in the heapsize properties in the > ams-hbase-env.sh and ams-env templates, and the user was not allowed to give > the "m" suffix in the UI. > > When a 2.1.2 blueprint is used to deploy Ambari 2.1.3, AMS does not start due > to invalid heap properties. > > FIX > The input heapsize parameter can either be 512 (UI) or 512m (blueprint). The > "m" is added to the former case programmatically to achieve uniformity. The > ams-hbase-content will not have "m" appended to any property. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java > f6d5cca > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml > 8705435 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml > f7fac44 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/functions.py > 01315e5 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > 68a3daa > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java > 994fb40 > > Diff: https://reviews.apache.org/r/40812/diff/ > > > Testing > ------- > > Relevant Java and Python unit tests pass. > > Tested manually on cluster. > > > Thanks, > > Aravindan Vijayan > >
