-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40805/#review108647
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
 (lines 284 - 286)
<https://reviews.apache.org/r/40805/#comment168101>

    Why is this check inside of an if-statement? By virtue of the fact that 
you're in the `updateResourcesAuthorized` method, wouldn't that mean that you 
need to run this check regardless of what data is in the map?


- Jonathan Hurley


On Dec. 1, 2015, 9:24 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40805/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 9:24 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
> Papirkovskyy, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-14114
>     https://issues.apache.org/jira/browse/AMBARI-14114
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Enforce granular role-based access control for stack version functions:
> 
>                            | Cluster User | Service Operator | Service 
> Administrator | Cluster Operator | Cluster Administrator | Administrator 
> ---------------------------|--------------|------------------|-----------------------|------------------|-----------------------|---------------
>                                                        
> View stack version details | (+)          | (+)              | (+)            
>        | (+)              | (+)                   | (+)
> Manage stack versions      |              |                  |                
>        |                  |                       | (+)
> Edit stack repository URLs |              |                  |                
>        |                  |                       | (+)
> 
> Entry points affected:
> - GET /api/v1/stacks/:stack_name/versions/:version_id
> - GET /api/v1/stacks/:stack_name/versions/:version_id
> - PUT /api/v1/stacks/:stack_name/versions/:version_id
> - POST /api/v1/stacks/:stack_name/versions/:version_id
> - DELETE /api/v1/stacks/:stack_name/versions/:version_id
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
>  062b0cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
>  7f88286 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java
>  4e4386e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
>  dfaef98 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
>  634d840 
> 
> Diff: https://reviews.apache.org/r/40805/diff/
> 
> 
> Testing
> -------
> 
> manually tested
> 
> # Local test resuts:
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 59:46.219s
> [INFO] Finished at: Mon Nov 30 18:47:07 EST 2015
> [INFO] Final Memory: 66M/923M
> [INFO] 
> ------------------------------------------------------------------------
> 
> # Jenkins test resuts:
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Reply via email to