----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40852/#review108664 -----------------------------------------------------------
Ship it! - Nate Cole On Dec. 1, 2015, 10:11 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40852/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2015, 10:11 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan > Hurley, Nate Cole, and Swapan Shridhar. > > > Bugs: AMBARI-14147 > https://issues.apache.org/jira/browse/AMBARI-14147 > > > Repository: ambari > > > Description > ------- > > HDP Version: 2.2.8.0-3150 > Kafka service > Rolling Upgrade to 2.3.4.0-3335, then downgrade > > Kafka broker restart failed on downgrade. (Upgrade had no issues) > > ``` > Traceback (most recent call last): > File > \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py\", > line 101, in <module> > KafkaBroker().execute() > File > \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\", > line 217, in execute > method(env) > File > \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\", > line 506, in restart > self.pre_upgrade_restart(env, upgrade_type=upgrade_type) > File > \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py\", > line 67, in pre_upgrade_restart > self.configure(env) > File > \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py\", > line 44, in configure > kafka() > File > \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py\", > line 53, in kafka > listeners = kafka_server_config['listeners'].replace(\"localhost\", > params.hostname) > KeyError: 'listeners'", > ``` > > > This happened because the code in kafka.py is comparing against > params.hdp_stack_version (which stays as HDP 2.3 during a downgrade) instead > of params.version (which is the version either upgrading or downgrading to). > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py > 2bd93d2 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py > 3caeb6d > > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml > f4c7f61 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml > b48184e > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > 766f443 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > 0c18f32 > > Diff: https://reviews.apache.org/r/40852/diff/ > > > Testing > ------- > > EU and RU from HDP 2.2 to 2.3 followed by downgrade. > Python unit tests passed, > > ---------------------------------------------------------------------- > Total run:839 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
