----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40853/#review108689 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java (line 340) <https://reviews.apache.org/r/40853/#comment168144> I know this doesn't follow the current convention, but I propose that we start making all named keys (FK, PK, UQ) in lowercase. This will help us out in the upgrade catalogs especially for DBs that are configured to be case sensitive. - Alejandro Fernandez On Dec. 2, 2015, 2:13 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40853/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 2:13 a.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton. > > > Bugs: AMBARI-14144 > https://issues.apache.org/jira/browse/AMBARI-14144 > > > Repository: ambari > > > Description > ------- > > ``` > ALTER TABLE permission_roleauthorization ADD CONSTRAINT > FK_permission_roleauthorization_permission_id FOREIGN KEY (permission_id) > REFERENCES adminpermission(permission_id) > Error report - > SQL Error: ORA-00972: identifier is too long > 00972. 00000 - "identifier is too long" > *Cause: An identifier with more than 30 characters was specified. > *Action: Specify at most 30 characters. > ``` > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java > 5f7e850 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3941ccf > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql bcf6d01 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 547c40f > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > e78aa17 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e3ae8fd > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 16354f6 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java > 0861878 > > Diff: https://reviews.apache.org/r/40853/diff/ > > > Testing > ------- > > Manually testing clean install and upgrade > > # Local test results: PASSED > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
