----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40883/#review108734 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java (line 203) <https://reviews.apache.org/r/40883/#comment168199> This is actually bad practice I think. Two non-equal objects can return the same hashcode. Safer to do the explicit variable comparisons. - Jonathan Hurley On Dec. 2, 2015, 5:04 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40883/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 5:04 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-14164 > https://issues.apache.org/jira/browse/AMBARI-14164 > > > Repository: ambari > > > Description > ------- > > During EU, an error was encountered preventing the removal of configurations. > The equals() method was forcing a lazy-load of data for an entity that didn't > exist. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java > f28cc02 > > Diff: https://reviews.apache.org/r/40883/diff/ > > > Testing > ------- > > No new tests required. Manual upgrade worked. Automated to confirm no > breakage pending. > > > Thanks, > > Nate Cole > >
