> On Dec. 3, 2015, 2:33 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java, > > line 277 > > <https://reviews.apache.org/r/40926/diff/1/?file=1153055#file1153055line277> > > > > Why does LOG.debug need to check if LOG.isDebugEnabled? > > Shouldn't the logging level exclude messages below the level?
Because the parameters like StringUtils.join(...) will be evaluated even if not in DEBUG mode. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40926/#review108865 ----------------------------------------------------------- On Dec. 3, 2015, 2:23 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40926/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2015, 2:23 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole. > > > Bugs: AMBARI-14191 > https://issues.apache.org/jira/browse/AMBARI-14191 > > > Repository: ambari > > > Description > ------- > > Hosts which have been excluded from the upgrade because they are in > maintenance mode are still selected as candidate hosts for service checks. > > STR > - deploy cluster with host without masters > - put this host in MM > - perform Express Upgrade > > Result: Host in Maintains Mode affected by Express Upgrade on HDFS service > check step > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java > dc88a5f > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 9ba5a22 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 748dbbe > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > baa394c > > Diff: https://reviews.apache.org/r/40926/diff/ > > > Testing > ------- > > Tests run: 3499, Failures: 0, Errors: 0, Skipped: 28 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 34:05 min > [INFO] Finished at: 2015-12-03T13:42:06-05:00 > [INFO] Final Memory: 38M/871M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
