> On Дек. 3, 2015, 7:41 п.п., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py,
> > line 89
> > <https://reviews.apache.org/r/40918/diff/2/?file=1152971#file1152971line89>
> >
> > Not fully sure if starts with "/" is valid.
>
> Sid Wagle wrote:
> It is possible that with core-site in the classpath hbase does not need
> specific file protcol specification. In that case this condition would not
> hold true.
> Can we simply check for the distributed flag?
I'm also not sure about hbase_root_dir.startswith('/'), but why not to check
Distributed flag does not say anything about FS, it says how many daemons to
run. Distributed HBase can be run with rootdir='file:///var....'
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40918/#review108868
-----------------------------------------------------------
On Дек. 3, 2015, 3:57 п.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40918/
> -----------------------------------------------------------
>
> (Updated Дек. 3, 2015, 3:57 п.п.)
>
>
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
>
>
> Bugs: AMBARI-14184
> https://issues.apache.org/jira/browse/AMBARI-14184
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In general, HDFS (hdfs://) is only of the many protocols that are valid for
> AMS usage. WASB:// is also an HCFS (hadoop compatible FS) which supports most
> if not all hadoop commands. So AMS scripts should create the hbase root dir
> etc in the same way as for HDFS.
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
> 84aaa0e
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
> cc86e27
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
> 8b99f96
>
> Diff: https://reviews.apache.org/r/40918/diff/
>
>
> Testing
> -------
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Dmytro Sen
>
>
