> On Dec. 4, 2015, 7:39 p.m., Tom Beerbower wrote: > > +1 > > > > It seems a bit strange to have the hook configuration in hive-site. I > > wonder if long term it would be cleaner for each hook to have its own > > config files. Just a thought.
I completely agree Tom but changing this wasn't an option at this time. - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40974/#review109019 ----------------------------------------------------------- On Dec. 4, 2015, 6:08 p.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40974/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 6:08 p.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-14218 > https://issues.apache.org/jira/browse/AMBARI-14218 > > > Repository: ambari > > > Description > ------- > > The following Atlas related configuration properties need to be added to > hive-site.xml for use by the Atlas Hive hook. > atlas.hook.hive.minThreads=1 > atlas.hook.hive.maxThreads=1 > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-site.xml > 5d0f5e0 > > Diff: https://reviews.apache.org/r/40974/diff/ > > > Testing > ------- > > Functional: > - deployed cluster with Hive service successfully > Unit Tests: > Full unit test suite passed: > > Results : > Tests run: 3543, Failures: 0, Errors: 0, Skipped: 28 > ... > Total run:810 > Total errors:0 > Total failures:0 > > > Thanks, > > John Speidel > >
