> On Dec. 3, 2015, 7:27 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml, > > line 82 > > <https://reviews.apache.org/r/40912/diff/1/?file=1152941#file1152941line82> > > > > This doesn't make sense. This says, > > if "xasecure.audit.destination.hdfs" is false, then set it to false > > > > Same issue for the property below with a condition that true stays true. > > the construct of > > > > <set key="propname" value="value" /> can be used to forcefully set the > > value. > > Gautam Borad wrote: > The reason why this condition was added is : > > on HDP-2.3 default value of xasecure.audit.destination.hdfs is true. > While testing EU from 2.2 to 2.3, it was observed that: even if > xasecure.audit.destination.hdfs value is false in HDP-2.2 after upgrading to > HDP-2.3 it becomes true.
Seems like if default changes, EU will modify the value to be from old default to new default. Alejandro when you get a chance can you check? - Sumit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40912/#review108862 ----------------------------------------------------------- On Dec. 4, 2015, 12:29 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40912/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 12:29 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, > Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: AMBARI-14169 > https://issues.apache.org/jira/browse/AMBARI-14169 > > > Repository: ambari > > > Description > ------- > > Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to > 2.3 after Smart Config changes. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml > 007f6a4 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > 98e8e4f > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 88eb9ac > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > 54236cf > > Diff: https://reviews.apache.org/r/40912/diff/ > > > Testing > ------- > > Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of > properties. > ----------------------------------------------------------------------- > Ran 271 tests in 8.739s > > OK > ---------------------------------------------------------------------- > Total run:879 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Gautam Borad > >
