-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41063/
-----------------------------------------------------------

(Updated Dec. 8, 2015, 12:12 a.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-14257
    https://issues.apache.org/jira/browse/AMBARI-14257


Repository: ambari


Description (updated)
-------

Problem
Storm metrics do not work after upgrading from versions < 2.1.1 to 2.1.2. 
ClassNotFound exception seen in the logs when storm metrics reporter class is 
accessed.

Bug
Storm lib directory is usually found in /usr/hdp/current/<storm_component>/lib. 
In the code we try to delete the link from /usr/lib/storm/lib which is not 
present. Hence, we never update the symlink in the actual location thus causing 
a stale symlink.

Fix
Change the symlink deletion logic to look at the correct location. 

Fix a bug in resource_management.system module where the action='delete' for 
Links must call the os.path.lexists rather than os.path.exists to return true 
for broken symlinks


Diffs
-----

  ambari-common/src/main/python/resource_management/core/providers/system.py 
a3b01f0 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py
 51998fa 

Diff: https://reviews.apache.org/r/41063/diff/


Testing
-------

Manual testing done.

Python unit tests pass.


Thanks,

Aravindan Vijayan

Reply via email to