----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41132/#review109498 -----------------------------------------------------------
Ship it! Ship It! - Oliver Szabo On Dec. 9, 2015, 10:50 a.m., Sebastian Toader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41132/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2015, 10:50 a.m.) > > > Review request for Ambari, Andrew Onischuk and Oliver Szabo. > > > Bugs: AMBARI-14287 > https://issues.apache.org/jira/browse/AMBARI-14287 > > > Repository: ambari > > > Description > ------- > > Ranger admin HA installation fails when the cluster is deployed with a > Blueprint that has stack advisor enabled with: > 'unicode' object has no attribute 'isempty' > > Removed the isempty() function call as there is no such function on python > string. It's enough just to call strip() on the string and verify that is not > empty. > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > f3e6f8b > > Diff: https://reviews.apache.org/r/41132/diff/ > > > Testing > ------- > > Deployed a cluster of 3 nodes using Blueprint having Ranger Admin in HA mode > and cluster creation template with stack advisor enabled > ("config_recommendation_strategy" : "ALWAYS_APPLY"). > > Verified that ranger admin installed correctly and also the plugins > registered with ranger. > > Python unit test results: > OK > ---------------------------------------------------------------------- > Total run:814 > Total errors:0 > Total failures:0 > OK > INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server > INFO: Return code from stack upgrade command, retcode = 0 > StackAdvisor implementation for stack HDP1, version 2.0.6 was not found > Returning DefaultStackAdvisor implementation > StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded > StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded > Returning XYZ101StackAdvisor implementation > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:23.788s > [INFO] Finished at: Wed Dec 09 11:48:50 CET 2015 > [INFO] Final Memory: 53M/811M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sebastian Toader > >
