----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41183/#review109773 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Dec. 9, 2015, 9:56 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41183/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2015, 9:56 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav > Papirkovskyy, Nate Cole, and Sumit Mohanty. > > > Bugs: AMBARI-14197 > https://issues.apache.org/jira/browse/AMBARI-14197 > > > Repository: ambari > > > Description > ------- > > Enforce granular role-based access control for Views functions: > > |View User | Cluster User | Service Operator | Service > Administrator | Cluster Operator | Cluster Administrator | Administrator > ---------------------|----------|--------------|------------------|-----------------------|------------------|-----------------------|--------------- > > Manage Ambari Views | | | | > | | | (+) > Use Ambari View | (+) | | | > | | | > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java > 05c5079 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java > 71d0826 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProvider.java > a1a9c46 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java > bc92a91 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java > 21745b4 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java > 1b3e6f4 > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 895e987 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java > 1af7264 > > ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java > 8abe757 > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java > 03a7442 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > f94cb25 > > Diff: https://reviews.apache.org/r/41183/diff/ > > > Testing > ------- > > Manually tested > > # Local test results: > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:00:38.797s > [INFO] Finished at: Wed Dec 09 18:44:42 EST 2015 > [INFO] Final Memory: 68M/1556M > [INFO] > ------------------------------------------------------------------------ > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
