----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41399/#review110494 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Dec. 15, 2015, 4:26 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41399/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 4:26 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-14373 > https://issues.apache.org/jira/browse/AMBARI-14373 > > > Repository: ambari > > > Description > ------- > > Given code like > > > > > base_dirs = [params.kafka_log_dir, params.kafka_pid_dir, > params.conf_dir] > Directory(base_dirs, > mode=0755, > cd_access='a', > owner=params.kafka_user, > group=params.user_group, > recursive=True > ) > set_dir_ownership(base_dirs) > > > base_dirs becomes empty after using it in Directory definition (there is a > side effect here) > > > Diffs > ----- > > ambari-common/src/main/python/resource_management/core/base.py 1711c22 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py > f02be4b > > Diff: https://reviews.apache.org/r/41399/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
