----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41710/#review111857 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On Dec. 24, 2015, 1 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41710/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2015, 1 p.m.) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-14454 > https://issues.apache.org/jira/browse/AMBARI-14454 > > > Repository: ambari > > > Description > ------- > > During Hiveserver2 start script, a directory create request is sent using the > below JSON structcture but the permission request sent from fast-hdfs- > resource.jar is different from the original permission (777) defined in the > JSON file. It looks the mode is getting treated as Dec instead of OCT. > > > > > {"target": "/apps/hive/warehouse", "dfs_type": "HCFS", "action": > "create", "mode": "777", "owner": "hive", "type": "directory"}, > > > <https://github.com/apache/ambari/blob/trunk/contrib/fast-hdfs-resource/src/ma > in/java/org/apache/ambari/fast_hdfs_resource/Resource.java#L217> > > To verify, if we change the json to below then we are actually getting correct > permission. > > > > > {"target": "/apps/hive/warehouse", "dfs_type": "HCFS", "action": > "create", "mode": "511", "owner": "hive", "type": "directory"} > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/files/fast-hdfs-resource.jar > 98a7f66 > > contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java > 3d2f182 > > Diff: https://reviews.apache.org/r/41710/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
