----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42060/#review113600 -----------------------------------------------------------
Ship it! Ship It! - Yusaku Sako On Jan. 8, 2016, 3:30 a.m., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42060/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 3:30 a.m.) > > > Review request for Ambari and Yusaku Sako. > > > Bugs: AMBARI-14583 > https://issues.apache.org/jira/browse/AMBARI-14583 > > > Repository: ambari > > > Description > ------- > > visualsearch.js https://documentcloud.github.io/visualsearch/ > will be used as the library for host page combo filter. We need to import > this library into ambari-web. > > Notice: 'ui-autocomplete' has been changed to 'autocomplete' in > visualsearch.js for compatibility with jquery ui 1.8.23 > > > Diffs > ----- > > LICENSE.txt 14f884e > ambari-web/app/config.js 098a0dc > ambari-web/app/templates/main/host.hbs 66d38e4 > ambari-web/app/templates/main/host/combo_search_box.hbs PRE-CREATION > ambari-web/app/views.js 3a4fb4d > ambari-web/app/views/main/host/combo_search_box.js PRE-CREATION > ambari-web/config.coffee 2922593 > ambari-web/karma.conf.js 3a54978 > ambari-web/vendor/scripts/backbone.js PRE-CREATION > ambari-web/vendor/scripts/jquery.ui.autocomplete.js PRE-CREATION > ambari-web/vendor/scripts/jquery.ui.position.js PRE-CREATION > ambari-web/vendor/scripts/underscore.js PRE-CREATION > ambari-web/vendor/scripts/visualsearch.js PRE-CREATION > ambari-web/vendor/styles/visualsearch.css PRE-CREATION > > Diff: https://reviews.apache.org/r/42060/diff/ > > > Testing > ------- > > Manually tested on live cluster. All unit tests passed. > 22941 tests complete (16 seconds) > 163 tests pending > > > Thanks, > > Richard Zang > >
