-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42204/
-----------------------------------------------------------
(Updated Jan. 14, 2016, 12:12 a.m.)
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Changes
-------
Addressed review comments.
Bugs: AMBARI-14636
https://issues.apache.org/jira/browse/AMBARI-14636
Repository: ambari
Description
-------
Based on the value of the timeline.metrics.service.operation.mode config in
ams-site, the following configs and respective values are recommended and
validated.
hbase.rootdir
hbase.cluster.distributed.
hbase.zookeeper.property.clientPort
dfs.client.read.shortcircuit
Value Guidance Matrix.
timeline.metrics.service.operation.mode embedded
distributed
hbase.rootdir
file:///var/lib/ambari-metrics-collector/hbase core-site:fs.defaultFs +
/user/ams/hbase
hbase.cluster.distributed. false
true
hbase.zookeeper.property.clientPort 61181 (default)
2181 (cluster Zk port)
dfs.client.read.shortcircuit true
true (if DN present along with collector, else false)
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml
5f0ac12
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py
a4c602e
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py
c37f2ab
ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 983109a
Diff: https://reviews.apache.org/r/42204/diff/
Testing
-------
Manual testing done.
ambari-server python unit tests pass.
Unit tests succeeded locally.
[INFO] Ambari Main ....................................... SUCCESS [6.451s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.036s]
[INFO] Ambari Web ........................................ SUCCESS [45.123s]
[INFO] Ambari Views ...................................... SUCCESS [3.147s]
[INFO] Ambari Admin View ................................. SUCCESS [11.186s]
[INFO] ambari-metrics .................................... SUCCESS [0.830s]
[INFO] Ambari Metrics Common ............................. SUCCESS [2.092s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [4.337s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [2.134s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [3.017s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.220s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [1:03.301s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [2.517s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [10.586s]
[INFO] Ambari Server ..................................... SUCCESS
[1:19:28.242s]
[INFO] Ambari Agent ...................................... SUCCESS [9.153s]
[INFO] Ambari Client ..................................... SUCCESS [0.050s]
[INFO] Ambari Python Client .............................. SUCCESS [0.473s]
[INFO] Ambari Groovy Client .............................. SUCCESS [10.459s]
[INFO] Ambari Shell ...................................... SUCCESS [0.034s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.039s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [7.190s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:22:32.356s
[INFO] Finished at: Tue Jan 12 14:01:09 PST 2016
[INFO] Final Memory: 90M/1369M
[INFO] ------------------------------------------------------------------------
Submitted patch through Apache.
Thanks,
Aravindan Vijayan
