-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42501/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 4:20 p.m.)
Review request for Ambari, Robert Levas, Robert Nettleton, Sandor Magyari,
Sumit Mohanty, and Sebastian Toader.
Bugs: AMBARI-14722
https://issues.apache.org/jira/browse/AMBARI-14722
Repository: ambari
Description
-------
If the config_recommendation_strategy is 'ONLY_STACK_DEFAULTS_APPLY' in the
cluster creation template, it should apply configurations only on stack
defaults.
In case of a user overrides a stack default property, stack advisor output
should not be considered, and force to use the user provided property.
(ALWAYS_APPLY strategy still won't use user provided properties in the output
of stack advisor, only as inputs)
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
337ad06
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java
60a8dde
Diff: https://reviews.apache.org/r/42501/diff/
Testing (updated)
-------
FT: provision with multiple blueprints (with user provided properties in the
cluster-creation tempalte and in the blueprint too)
Unit testing done.
Total run:831
Total errors:0
Total failures:0
OK
INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
INFO: Return code from stack upgrade command, retcode = 0
StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
Returning DefaultStackAdvisor implementation
StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
Returning XYZ101StackAdvisor implementation
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:00:46.271s
[INFO] Finished at: Tue Jan 19 16:55:58 CET 2016
[INFO] Final Memory: 39M/1277M
[INFO] ------------------------------------------------------------------------
Thanks,
Oliver Szabo