----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42598/#review115615 -----------------------------------------------------------
ambari-common/src/main/python/ambari_commons/firewall.py (line 140) <https://reviews.apache.org/r/42598/#comment176601> What the previous type of firewall? I think we should support both of them? A not just switch from one to other. - Andrew Onischuk On Jan. 21, 2016, 1:40 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42598/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2016, 1:40 p.m.) > > > Review request for Ambari, Andrew Onischuk and Myroslav Papirkovskyy. > > > Bugs: AMBARI-14757 > https://issues.apache.org/jira/browse/AMBARI-14757 > > > Repository: ambari > > > Description > ------- > > Steps to reproduce: > 1. Install claster > 2. Go to host page. > 3. Click "Add Host" in the "Actions" > 4. Go to the host through SSH in your terminal > 5. Run command "yast2 firewall services add service=service:sshd zone=EXT" to > enable ssh connection in firewall. > 6. Run command "/sbin/rcSuSEfirewall2 start" to start firewall. > 7. Return to browser and complete fields "target hosts" and key > 8. Press "Register and Confirm" and wait for Host check > 9. Click "Click here to see warnings" and watch label "Firewall issues" > (There is no issues, but it should be) > > > Diffs > ----- > > ambari-common/src/main/python/ambari_commons/firewall.py e6a1ff9 > ambari-server/src/test/python/TestAmbariServer.py fdc375b > > Diff: https://reviews.apache.org/r/42598/diff/ > > > Testing > ------- > > Unit tests passed > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Server ..................................... SUCCESS [52.309s] > [INFO] Ambari Agent ...................................... SUCCESS [21.457s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:14.741s > [INFO] Finished at: Thu Jan 21 14:57:28 EET 2016 > [INFO] Final Memory: 61M/1102M > [INFO] --------------------------------------------------------- > > > Thanks, > > Dmytro Sen > >
