----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43337/#review118336 -----------------------------------------------------------
Ship it! Ship It! - Sid Wagle On Feb. 8, 2016, 11:33 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43337/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2016, 11:33 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku > Sako. > > > Bugs: AMBARI-14962 > https://issues.apache.org/jira/browse/AMBARI-14962 > > > Repository: ambari > > > Description > ------- > > TODO > Invoke Grafana's create datasource REST call to configure the datasource as > part of AMS UI lifecycle commands (say "Start"). > > IMPLEMENTATION LOGIC > > . During Grafana START > . Check if AMBARI_METRICS datasource already exists in Grafana. > . If datasource EXISTS > . Check Collector Host is valid. > . If not valid, delete obselete datasource entry from Grafana. > . If Collector host valid, skip_creating_datasource = True. > . If skip_creating_datasource != True > . Create datasource with name = AMBARI_METRICS and URL as the current > collector URL. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py > f876036 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metrics_grafana_datasource.json.j2 > PRE-CREATION > > ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py > 5bc1412 > > Diff: https://reviews.apache.org/r/43337/diff/ > > > Testing > ------- > > Manual testing done. > > Added Unit tests > > > Thanks, > > Aravindan Vijayan > >
