----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43421/#review118810 -----------------------------------------------------------
Ship it! Ship It! - Sumit Mohanty On Feb. 11, 2016, 3:27 a.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43421/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2016, 3:27 a.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, Srimanth Gunturi, and > Yusaku Sako. > > > Bugs: AMBARI-14989 > https://issues.apache.org/jira/browse/AMBARI-14989 > > > Repository: ambari > > > Description > ------- > > Hive in Ambari shows enabling CBO at two places "settings tab" and "Advanced > tab". By default both of them have same value but there is a possibility that > due to some user actions, values at these two places may differ and create > confusion. > > There seems to be additional ambari maintained property for CBO which should > not be needed as hive inherently has this property in hve-site.xml. > The submitted patch removes ambari maintained property which was shown in > Advanced hive-env section. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml > f84bc01 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml > cc3e75f > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 9be6410 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-env.xml > 3d1b549 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-site.xml > 7e13436 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py > c6941f0 > > ambari-server/src/test/python/stacks/2.1/configs/hive-metastore-upgrade.json > 7829f05 > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 904688a > ambari-server/src/test/python/stacks/2.3/common/services-sparkts-hive.json > 51ae36a > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 79f4f79 > > Diff: https://reviews.apache.org/r/43421/diff/ > > > Testing > ------- > > Verified manually on the cluster > Verified on branch-2.2 that all ambari-server python tests passes > successfully: > ---------------------------------------------------------------------- > Ran 242 tests in 7.231s > OK > ---------------------------------------------------------------------- > Total run:881 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Jaimin Jetly > >
