-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43609/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley, Nate Cole, Oliver Szabo, and Robert 
Nettleton.


Bugs: AMBARI-15036
    https://issues.apache.org/jira/browse/AMBARI-15036


Repository: ambari


Description
-------

Return privilege information with results from GroupResourceProvider, which is 
invoked when issuing the following REST API call:
```
GET /api/v1/groups
```

The result set should looks something like:
```
{
  "href" : "http://ambari-server:8080/api/v1/groups?fields=privileges/*";,
  "items" : [
    {
      "href" : "http:///ambari-server:8080/api/v1/groups/group1";,
      "Groups" : {
        "group_name" : "group1"
      },
      "privileges" : [
        {
          "href" : 
"http://ambari-server:8080/api/v1/groups/group1/privileges/1";,
          "PrivilegeInfo" : {
            "cluster_name" : "c1",
            "permission_label" : "Cluster User",
            "permission_name" : "CLUSTER.USER",
            "principal_name" : "group1",
            "principal_type" : "GROUP",
            "privilege_id" : 3,
            "type" : "CLUSTER",
            "group_name" : "group1"
          }
        }
      ]
    }
  ]
}
```

The following entry points should exist as well:
```
GET /api/v1/groups/GROUP_NAME/privileges
```
```
GET /api/v1/groups/GROUP_NAME/privileges/PRIVILEGE_ID
```


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/GroupResourceDefinition.java
 783e04b 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 4c12094 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/GroupPrivilegeService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/GroupService.java
 ee71719 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
 da334b2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 f5fa5f1 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/GroupPrivilegeServiceTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/43609/diff/


Testing
-------

Manually tested

# Jenkins test results: PENDING


Thanks,

Robert Levas

Reply via email to