----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43736/#review119747 -----------------------------------------------------------
Instead of creating a new AlertConfigConnectionTimeoutView, we can add a parameter based badge section for currently used AlertConfigTextFieldView. - Richard Zang On Feb. 18, 2016, 9:01 p.m., Zhe (Joe) Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43736/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 9:01 p.m.) > > > Review request for Ambari, Richard Zang, Srimanth Gunturi, and Yusaku Sako. > > > Bugs: AMBARI-15096 > https://issues.apache.org/jira/browse/AMBARI-15096 > > > Repository: ambari > > > Description > ------- > > For WEB alerts, the Connection Timeout fields should show CRITICAL badge > since if the connection times out, it is a critical situation. > > > Diffs > ----- > > ambari-web/app/models/alerts/alert_config.js 867b45a > > ambari-web/app/templates/main/alerts/configs/alert_config_connection_timeout.hbs > PRE-CREATION > ambari-web/app/views/main/alerts/definition_configs_view.js 00e26d4 > > Diff: https://reviews.apache.org/r/43736/diff/ > > > Testing > ------- > > Local ambari-web test passed. > 24271 tests complete (21 seconds) > 156 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
