> On Feb. 18, 2016, 5:16 p.m., jun aoki wrote: > > ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js, line 51 > > <https://reviews.apache.org/r/43644/diff/2/?file=1252999#file1252999line51> > > > > This may not be used as it is about started vs total?
It is being used for stopped. You'll see it when you hover over the widget. Installed refers to that the component is in actual stopped state. It is better than computing the difference between total and started. A possible state is 'starting' which is neither 'started' not 'installed' (which corresponds to stopped). - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43644/#review119750 ----------------------------------------------------------- On Feb. 18, 2016, 5:52 p.m., Matt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43644/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 5:52 p.m.) > > > Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh > chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, and > Oleksandr Diachenko. > > > Bugs: AMBARI-15060 > https://issues.apache.org/jira/browse/AMBARI-15060 > > > Repository: ambari > > > Description > ------- > > The no. of HAWQ segments alive should be displayed as a widget on Ambari's > main dashboard. > > > Diffs > ----- > > ambari-web/app/assets/test/tests.js 25c3f43 > ambari-web/app/mappers/components_state_mapper.js 0f2b627 > ambari-web/app/messages.js a7e4ff3 > ambari-web/app/views.js 7e461f9 > ambari-web/app/views/main/dashboard/widgets.js b99d881 > ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js > PRE-CREATION > ambari-web/test/views/main/dashboard/widgets/hawqsegment_live_test.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/43644/diff/ > > > Testing > ------- > > Manually Test: results pending. > Images attached to JIRA. > > Added additional unit test. > 10416 tests complete (10 seconds) > 121 tests pending > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 37.827 s > [INFO] Finished at: 2016-02-18T17:51:42-08:00 > [INFO] Final Memory: 12M/310M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Matt > >
