----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43756/#review119868 -----------------------------------------------------------
Ship it! Ship It! - Andrew Onischuk On Feb. 19, 2016, 11:42 a.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43756/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2016, 11:42 a.m.) > > > Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Myroslav > Papirkovskyy. > > > Bugs: AMBARI-15111 > https://issues.apache.org/jira/browse/AMBARI-15111 > > > Repository: ambari > > > Description > ------- > > Updating description / extracting comments: > The goal is to include additional information in the Email Alert message that > is sent out so it's easier for the user to known what to do when they receive > an alert. > 1) Include information about the affected host for the specific alert being > fired. For example, If the alert is about a DataNode process, then we should > also be including the hostname that is affected (i.e. running the DataNode). > In some cases, alerts are not host specific, and we can include "blank" in > the email template. > 2) Include information about the cluster name. People might be getting alerts > from > 1 cluster, so including the Cluster Name in the email Subject and Body > is useful > 3) If possible, can we have information about the Ambari Server host + URL > available for use in the template? Meaning: if we know the Ambari Server URL, > then format URL links in the email body (especially in the case of #1) so the > user can "just click" to go to a host... > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > edcfa28 > > ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java > a27bc1d > ambari-server/src/main/resources/alert-templates.xml d7fe320 > > Diff: https://reviews.apache.org/r/43756/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
