> On Feb. 21, 2016, 10:34 p.m., Matt wrote: > > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py, line > > 227 > > <https://reviews.apache.org/r/43771/diff/2/?file=1263588#file1263588line227> > > > > Thought the JIRA was about 'HAWQSEGMENT should not be recommended on a > > host without DATANODE'. > > > > I see no DATANODE on host-group-1, but the comment says HAWQSEGMENT > > should be recommended on host-group-1? I believe you meant to say that the > > recommendation should have neither of them on host-group-1.
The recommendations snippet in comment should not have any component on host-group-1, updated it, good catch. - bhuvnesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43771/#review120078 ----------------------------------------------------------- On Feb. 22, 2016, 2:23 a.m., bhuvnesh chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43771/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 2:23 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, > Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-15116 > https://issues.apache.org/jira/browse/AMBARI-15116 > > > Repository: ambari > > > Description > ------- > > This patches ensures that HAWQSEGMENT should not be recommended on host which > does not have DataNode at Assign Slaves and Client page. > Recommendation should always suggests to have HAWQSEGMENT colocated with > DATANODE. > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 34e4cfa > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 03ae6cc > > Diff: https://reviews.apache.org/r/43771/diff/ > > > Testing > ------- > > yes. manual > > > Thanks, > > bhuvnesh chaudhary > >
