----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44245/#review121570 -----------------------------------------------------------
Ship it! Ship It! - Yusaku Sako On March 2, 2016, 1:36 a.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44245/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 1:36 a.m.) > > > Review request for Ambari, Srimanth Gunturi and Yusaku Sako. > > > Bugs: AMBARI-15258 > https://issues.apache.org/jira/browse/AMBARI-15258 > > > Repository: ambari > > > Description > ------- > > 1. Hive Server Interactive should be not shoen on Assign Master page of > Installer/Add-Service wizard. > 2. Only when user selects interactive query to be true on Configure services > page for Hive then Assign Master popup should be shown > 3. It should not be possible to add additional Hive Server interactive from > Hosts page > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/configuration/llap-daemon-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/configuration/llap-env.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/metainfo.xml > 93728fd > > ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/themes/theme.json > PRE-CREATION > ambari-web/app/controllers.js 8fa9e6b > ambari-web/app/controllers/wizard/step7/assign_master_controller.js > PRE-CREATION > ambari-web/app/controllers/wizard/step7_controller.js fc6b5ab > ambari-web/app/controllers/wizard/step8_controller.js 911d0a8 > ambari-web/app/messages.js d0c8840 > ambari-web/app/mixins/wizard/assign_master_components.js 0500014 > ambari-web/app/models.js 01fe689 > ambari-web/app/models/configs/theme/config_action.js PRE-CREATION > ambari-web/app/models/stack_service_component.js a9b342b > ambari-web/app/templates/common/assign_master_components.hbs f7cebed > ambari-web/app/utils/configs/theme/theme.js a7d3b68 > ambari-web/app/views.js 9d606e9 > ambari-web/app/views/common/assign_master_components_view.js e37d864 > ambari-web/app/views/wizard/step7/assign_master_view.js PRE-CREATION > ambari-web/test/controllers/wizard/step8_test.js e647eda > > Diff: https://reviews.apache.org/r/44245/diff/ > > > Testing > ------- > > Manually tested installer and ADd service wizard > > verified that all unit tests passes successfully: > > 24542 tests complete (25 seconds) > 146 tests pending > > > Thanks, > > Jaimin Jetly > >
