----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44238/#review121735 -----------------------------------------------------------
Ship it! Ship It! - bhuvnesh chaudhary On March 1, 2016, 11:54 p.m., Lav Jain wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44238/ > ----------------------------------------------------------- > > (Updated March 1, 2016, 11:54 p.m.) > > > Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh > chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Jayush Luniya, Matt, Newton > Alex, Oleksandr Diachenko, Robert Levas, Sumit Mohanty, and Srimanth Gunturi. > > > Bugs: AMBARI-15254 > https://issues.apache.org/jira/browse/AMBARI-15254 > > > Repository: ambari > > > Description > ------- > > ConfigHelper.updateConfigType takes in config_type (e.g. hdfs-site), map of > updates (key value pairs) and a list of removals (properties). > > The current implementation is skipping the updates to configuration if the > Map of updates is empty, even if there are properties to be removed. > > This is causing problem during disabling of kerberos for some components > (like HAWQ) because some config parameters that are present in kerberos.json > must be removed. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > d311017 > > ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java > 9fe0fc3 > > Diff: https://reviews.apache.org/r/44238/diff/ > > > Testing > ------- > > Test case added. > > > Thanks, > > Lav Jain > >
