-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44211/#review122162
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
 (line 62)
<https://reviews.apache.org/r/44211/#comment184058>

    Do you want to start with 0, and increment it before each test is executed?



ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
 (line 98)
<https://reviews.apache.org/r/44211/#comment184059>

    Those detailed messages count for troubleshooting. Good work!


- jun aoki


On March 4, 2016, 4:41 a.m., Goutam Tadi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44211/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 4:41 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
> Lav Jain, Matt, and Newton Alex.
> 
> 
> Bugs: AMBARI-15249
>     https://issues.apache.org/jira/browse/AMBARI-15249
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> pxf service check failure does not tell why it fails. Include debug messages 
> for ease.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
>  6f60661 
> 
> Diff: https://reviews.apache.org/r/44211/diff/
> 
> 
> Testing
> -------
> 
> Yes, tested.
> 
> 
> Thanks,
> 
> Goutam Tadi
> 
>

Reply via email to