> On March 4, 2016, 7:36 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 953 > > <https://reviews.apache.org/r/42032/diff/1/?file=1186442#file1186442line953> > > > > I believe this can lead to more confusion. > > Especially if it is to be used by View X but not by View y.
Any view that wants to use the API uses this method, as far as I can tell. I don't think there is any other method for getting the API hostname in the Ambari codebase. At lesat I couldn't find one. Most of the views don't use the API, but a few do. The rest just worked out of the box. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42032/#review122140 ----------------------------------------------------------- On Jan. 7, 2016, 8:23 p.m., Greg Hill wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42032/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 8:23 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-12916 > https://issues.apache.org/jira/browse/AMBARI-12916 > > > Repository: ambari > > > Description > ------- > > This lets you configure the hostname that the Ambari server passes to the > views and agent so you can specify it differently from the system hostname. > This is useful in cases where you want to use a fqdn for API access but a > local hostname for local cluster communication. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 371d5d2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > a7f206a > > Diff: https://reviews.apache.org/r/42032/diff/ > > > Testing > ------- > > Honestly, not much. There weren't any existing unit tests for the code I > modified and I'm not a Java developer so I didn't really know where to start > with creating them. It's a pretty simple change and doesn't break any > existing tests, but I'm happy to do some more testing if someone can provide > some direction. > > > Thanks, > > Greg Hill > >
