> On March 4, 2016, 11:19 a.m., Robert Levas wrote: > > Thinking more about this, the Hadoop services as well as some other > > services, like Oozie, internally perform the `_HOST` replacment with the > > local host's hostname. This mechanism is not getting the hostname value > > from the ambari-agent config or ambari-server command files.. I assume uses > > something that generates a hostname value like `hostname -f`. > > > > With this in mind, it seems like _faking_ a hostname in the suggested > > mannor is a bad idea. > > Greg Hill wrote: > I understand. This isn't the norm. The default behavior hasn't changed, > but this gives a power user more flexibility to configure the agent to their > desired state. In my experience, making everything configurable, but with > sensible defaults is usually the best strategy. You can't predict every use > case, and there are legit reasons for wanting this capability. If it breaks > Oozie if I set it to something other than the recommended default, that's my > problem, isn't it? > > Also, being able to override the hostname isn't a new capability, it's > just that previously it required you to inject a custom script to do it and > this lets you do it directly in the config file.
"If it breaks Oozie if I set it to something other than the recommended default, that's my problem, isn't it?" Sort of.. but when someone does this and things break, it will probably be me trying to help out on the mailing lists or whatnot. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42031/#review122097 ----------------------------------------------------------- On Jan. 7, 2016, 3:17 p.m., Greg Hill wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42031/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 3:17 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-12915 > https://issues.apache.org/jira/browse/AMBARI-12915 > > > Repository: ambari > > > Description > ------- > > Adds an option to the agent config file to specify the hostname instead of > relying on the system hostname. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/hostname.py 9cb75d6 > ambari-agent/src/test/python/ambari_agent/TestHostname.py 3cf6b17 > > Diff: https://reviews.apache.org/r/42031/diff/ > > > Testing > ------- > > Added unit tests to confirm desired behavior. > > > Thanks, > > Greg Hill > >
